awesome

Welcome to awesome bug tracking system.
Tasklist

FS#646 - Float layout in all tags

Attached to Project: awesome
Opened by Ilya Sheshukov (Ilya Muromec) - Tuesday, 29 September 2009, 14:20 GMT
Last edited by Julien Danjou (jd) - Wednesday, 30 September 2009, 06:43 GMT
Task Type Bug Report
Category Core
Status Closed
Assigned To No-one
Operating System Linux
Severity Medium
Priority Normal
Reported Version git/master
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

If I comment float layout in rc.lua, on all tags will be only a float layout. If I didn't comment this line, it will be first. This is not a serious bug, but very annoying
This task depends upon

Closed by  Julien Danjou (jd)
Wednesday, 30 September 2009, 06:43 GMT
Reason for closing:  Not a bug
Comment by scio (scio) - Tuesday, 29 September 2009, 20:29 GMT
If I understand what you are saying correctly, this is the same problem I had after reinstalling. The default config does not specify a layout for the tags it creates which results in a float layout.

The simple fix is to modify your config where it creates the tags and add the last parameter of layouts[1].

Maybe this should also be done in the default config?
Comment by matt h (mharrison) - Tuesday, 29 September 2009, 20:37 GMT
Thanks to irc I've added the following to the loop in the -- {{{ Tags config

for i = 1, 9 do
awful.layout.set(awful.layout.suit.tile, tags[s][i])
end

But I think this is a regression (as in the default behavior changing), and would agree that this code should be added to the default config
Comment by scio (scio) - Tuesday, 29 September 2009, 20:45 GMT
It's actually easier than that:

Change:
44 -- {{{ Tags
45 -- Define a tag table which hold all screen tags.
46 tags = {}
47 for s = 1, screen.count() do
48 -- Each screen has its own tag table.
49 tags[s] = awful.tag({ 1, 2, 3, 4, 5, 6, 7, 8, 9 }, s)
50 end

To:
44 -- {{{ Tags
45 -- Define a tag table which hold all screen tags.
46 tags = {}
47 for s = 1, screen.count() do
48 -- Each screen has its own tag table.
49 tags[s] = awful.tag({ 1, 2, 3, 4, 5, 6, 7, 8, 9 }, s, layouts[1])
50 end

If I remember correctly, no need to loop through tags again after.
Comment by scio (scio) - Tuesday, 29 September 2009, 20:46 GMT
I realize now that is hard to read:
Change:
tags[s] = awful.tag({ 1, 2, 3, 4, 5, 6, 7, 8, 9 }, s)

to:
tags[s] = awful.tag({ 1, 2, 3, 4, 5, 6, 7, 8, 9 }, s, layouts[1])
Comment by Ilya Sheshukov (Ilya Muromec) - Wednesday, 30 September 2009, 02:56 GMT
Thanks, Adam. It works!

Loading...